Apply style guide section for JUnit#2212
Merged
Merged
Conversation
github-actions
Bot
assigned
atoulme,
breedx-splk,
cyrille-leclerc,
HaloFour,
jack-berg,
jackshirazi,
jeanbisutti,
JonasKunz,
jsuereth and
kenfinnigan
github-actions
Bot
requested review from
HaloFour,
JonasKunz,
LikeTheSalad,
MikeGoldsmith,
PeterF778,
atoulme,
breedx-splk,
cyrille-leclerc,
jack-berg,
jackshirazi,
jeanbisutti,
jsuereth,
kenfinnigan,
laurit,
mateuszrzeszutek,
oertl,
psx95,
robsunday and
srprash
September 6, 2025 18:36
github-actions
Bot
requested review from
SylvainJuge,
wangzlei and
zeitlinger
September 6, 2025 18:36
trask
marked this pull request as ready for review
September 6, 2025 18:41
zeitlinger
approved these changes
Sep 8, 2025
MikeGoldsmith
approved these changes
Sep 8, 2025
PeterF778
approved these changes
Sep 8, 2025
PeterF778
left a comment
PeterF778
left a comment
Contributor
There was a problem hiding this comment.
Looked at the consistent probability sampling code only - no issues.
SylvainJuge
approved these changes
Sep 9, 2025
SylvainJuge
left a comment
SylvainJuge
left a comment
Contributor
There was a problem hiding this comment.
LGTM for the following modules:
inferred-spansjmx-scraperspan-stacktrace
jaydeluca
approved these changes
Sep 10, 2025
jkwatson
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applying https://github.com/open-telemetry/opentelemetry-java-contrib/blob/main/docs/style-guide.md#junit