async profiler 4.1 update#2096
Merged
trask merged 3 commits intoopen-telemetry:mainfrom Aug 12, 2025
Merged
Conversation
…ontrib into renovate/tools.profiler-async-profiler-4.x
JonasKunz
approved these changes
Aug 12, 2025
1 task
trask
approved these changes
Aug 12, 2025
Member
|
thanks! |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
open-telemetry:main
with commit Aug 12, 2025
cab11c1
53 of 55 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #2060
Async profiler 4.1 introduces a new empty string in constant pool parsing that needs to be ignored when parsing.
I haven't searched which PR in 4.1 release notes is triggering this, but this seems related to https://github.com/async-profiler/async-profiler/blob/b320af7ad34a81fdce02ae64305e91dc4b0914d0/src/flightRecorder.cpp#L806 which was introduced about 6~8 months ago, so while this behavior was already present in 4.0 but not triggered.