jmx add link to jetty metrics for 2.18.0#2033
Merged
trask merged 1 commit intoopen-telemetry:mainfrom Jul 22, 2025
Merged
Conversation
laurit
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Once the instrumentation dependency is updated to
2.18.0, the jetty jmx metrics that are used byjmx-scraperwill be updated (see opentelemetry-java-instrumentation#14067 for details).This PR adds a link to their definitions in instrumentation for proper documentation.
This change should be merged as part of the
1.48.0release that will rely on instrumentation2.18.0, however since it's only documentation it can also be merged after.However, this should be included in the release notes as users of jmx-scraper with the following configuration will see changes in captured metrics:
otel.jmx.target.source=auto(default)otel.jmx.target.systemwithjetty