Skip to content

add declarative config for baggage#2031

Merged
trask merged 8 commits into
open-telemetry:mainfrom
zeitlinger:baggage-declarative-config
Sep 9, 2025
Merged

add declarative config for baggage#2031
trask merged 8 commits into
open-telemetry:mainfrom
zeitlinger:baggage-declarative-config

Conversation

@zeitlinger

@zeitlinger zeitlinger commented Jul 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #2013

@zeitlinger
zeitlinger force-pushed the baggage-declarative-config branch from f89cb52 to 507cef9 Compare August 15, 2025 11:57
@github-actions
github-actions Bot requested a review from MikeGoldsmith August 15, 2025 11:57
@zeitlinger
zeitlinger marked this pull request as ready for review August 15, 2025 12:57
@zeitlinger
zeitlinger requested a review from a team as a code owner August 15, 2025 12:57
@zeitlinger

zeitlinger commented Aug 18, 2025

Copy link
Copy Markdown
Member Author

@jaydeluca please have a look

trask
trask reviewed Aug 18, 2025
View reviewed changes
Comment thread baggage-processor/build.gradle.kts
trask
trask approved these changes Aug 19, 2025
View reviewed changes
Comment thread .../main/java/io/opentelemetry/contrib/baggage/processor/BaggageLogRecordComponentProvider.java
@trask trask added this to the v1.49.0 milestone Aug 19, 2025
@zeitlinger zeitlinger mentioned this pull request Aug 20, 2025
Open
@trask
trask added this pull request to the merge queue Aug 20, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 20, 2025
@trask
trask added this pull request to the merge queue Aug 20, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Aug 20, 2025
@laurit laurit mentioned this pull request Aug 21, 2025
Closed
@zeitlinger
zeitlinger force-pushed the baggage-declarative-config branch from 0072c76 to e4c885f Compare August 21, 2025 13:51
@trask

trask commented Aug 22, 2025

Copy link
Copy Markdown
Member

@zeitlinger 3 tests are still failing even after rerunning them, can you check? worried to merge and possibly make our flaky test situation worse

@zeitlinger

zeitlinger commented Aug 22, 2025

Copy link
Copy Markdown
Member Author

@zeitlinger 3 tests are still failing even after rerunning them, can you check? worried to merge and possibly make our flaky test situation worse

should be addressed with #2152

@trask trask removed this from the v1.49.0 milestone Aug 22, 2025
MikeGoldsmith
MikeGoldsmith approved these changes Aug 26, 2025
View reviewed changes

@MikeGoldsmith MikeGoldsmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @zeitlinger!

@github-actions
github-actions Bot requested a review from MikeGoldsmith August 26, 2025 20:41
@zeitlinger
zeitlinger force-pushed the baggage-declarative-config branch from c27c16f to 00c7b28 Compare September 3, 2025 12:24
@zeitlinger zeitlinger mentioned this pull request Sep 4, 2025
Merged
@zeitlinger
zeitlinger force-pushed the baggage-declarative-config branch from bfd00b9 to df6378e Compare September 5, 2025 16:37
@trask

trask commented Sep 8, 2025

Copy link
Copy Markdown
Member

@zeitlinger do you think there are any updates that make sense to the READMEs for declarative config support on these PRs?

@zeitlinger
zeitlinger force-pushed the baggage-declarative-config branch from df6378e to a840b47 Compare September 9, 2025 11:16
@otelbot-java-contrib

otelbot-java-contrib Bot commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

🔧 The result from spotlessApply was committed to the PR branch.

This was referenced Sep 9, 2025
Merged
Closed
@zeitlinger

zeitlinger commented Sep 9, 2025

Copy link
Copy Markdown
Member Author

@zeitlinger do you think there are any updates that make sense to the READMEs for declarative config support on these PRs?

done for this one - and later in the others once the config bridge is available

@trask
trask added this pull request to the merge queue Sep 9, 2025
Merged via the queue into open-telemetry:main with commit bb5449f Sep 9, 2025
25 checks passed
@zeitlinger
zeitlinger deleted the baggage-declarative-config branch September 9, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkwatson jkwatson jkwatson left review comments
@trask trask trask approved these changes
@MikeGoldsmith MikeGoldsmith Awaiting requested review from MikeGoldsmith

Assignees

@zeitlinger zeitlinger

@MikeGoldsmith MikeGoldsmith

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

declarative config: baggage processor

4 participants

@zeitlinger @trask @jkwatson @MikeGoldsmith