Declarative config: Cloud component providers#2014
Merged
trask merged 12 commits intoopen-telemetry:mainfrom Jul 22, 2025
Merged
Declarative config: Cloud component providers#2014trask merged 12 commits intoopen-telemetry:mainfrom
trask merged 12 commits intoopen-telemetry:mainfrom
Conversation
github-actions
Bot
assigned
breedx-splk,
cyrille-leclerc,
jsuereth,
kenfinnigan,
laurit,
trask and
zeitlinger
Member
Author
|
@jack-berg please have a look 😄 |
6 tasks
jaydeluca
approved these changes
Jul 18, 2025
jack-berg
approved these changes
Jul 19, 2025
Member
jack-berg
left a comment
jack-berg
left a comment
There was a problem hiding this comment.
Seems good! Just a question about whether these should go in internal packages, and some suggestions about testing.
|
|
||
| @Test | ||
| @SuppressWarnings("rawtypes") | ||
| void providerIsLoaded() { |
Member
There was a problem hiding this comment.
I wonder if there's any good way to do an end-to-end style test for these resource detectors like I did here: https://github.com/open-telemetry/opentelemetry-java-contrib/blob/main/samplers/src/test/java/internal/RuleBasedRoutingSamplerComponentProviderTest.java#L39
I.e.:
- Have a chunk of yaml that uses the
azureresource detector like users would - Call the SDK methods to parse the YAML and create SDK components from it
- Assert that the resource contains expected attributes
This has the benefit of being able to act as a form of documentation for users.
The assertions may be difficult though because OpenTelemetrySdk doesn't make it easy to access the resource.
Member
Author
There was a problem hiding this comment.
great idea - I'll create a follow-up PR for this.
zeitlinger
force-pushed
the
cloud-component-providers
branch
from
350bcd4 to
81d90f9
Compare
zeitlinger
moved this from Awaiting Review
to Blocked
in Declarative Configuration: Java
zeitlinger
force-pushed
the
cloud-component-providers
branch
from
81d90f9 to
ea833b9
Compare
github-project-automation
Bot
moved this from Blocked
to Done
in Declarative Configuration: Java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of open-telemetry/opentelemetry-java-instrumentation#14081