GCP Auth: update header injection implementation#1860
Merged
trask merged 6 commits intoopen-telemetry:mainfrom Apr 23, 2025
Merged
GCP Auth: update header injection implementation#1860trask merged 6 commits intoopen-telemetry:mainfrom
trask merged 6 commits intoopen-telemetry:mainfrom
Conversation
aabmass
reviewed
Apr 22, 2025
Member
aabmass
left a comment
There was a problem hiding this comment.
LGTM. Is there a test case verifying that no quota project is sent when using a service account from metadata server?
aabmass
approved these changes
Apr 22, 2025
Contributor
Author
The behavior being tested is - if quota project header is not present in the metadata server, then it is not expected to be in the export headers. The auth extension is agnostic to the specific sub-type of |
jsuereth
approved these changes
Apr 23, 2025
trask
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Updates the internal implementation such that the required headers are retrieved from the Google Auth Library instead of manually constructing and passing them.
Also fixes flaky unit tests which were affected because of external environment variables.
Testing:
Outstanding items: