Fix To Ignore empty baggage keys in ImmutableBaggage.put#8658
Open
NithinU2802 wants to merge 1 commit into
Open
Fix To Ignore empty baggage keys in ImmutableBaggage.put#8658NithinU2802 wants to merge 1 commit into
NithinU2802 wants to merge 1 commit into
Conversation
Pull request dashboard statusStatus last refreshed: 2026-07-26 18:31:11 UTC.
This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8658 +/- ##
============================================
- Coverage 91.46% 91.46% -0.01%
+ Complexity 10457 10456 -1
============================================
Files 1021 1021
Lines 27647 27647
Branches 3242 3242
============================================
- Hits 25288 25287 -1
Misses 1616 1616
- Partials 743 744 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Hi @jack-berg, could you please review this PR when you get a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, ImmutableBaggage.put Line 72 accepted empty baggage keys, allowing entries with an empty key to be added to a Baggage. The implementation has been updated to ignore empty keys, aligning the behavior with the OpenTelemetry Baggage API specification. A test has also been updated to verify that attempting to add an empty key leaves the Baggage unchanged by updating ImmutableBaggage.put_keyEmpty Line 115.
I'm happy to discuss and update any changes if needed.
Closes #8657