Solve experimental properties on stable APIs in declarative config generated pojos#8654
Open
jack-berg wants to merge 1 commit into
Open
Solve experimental properties on stable APIs in declarative config generated pojos#8654jack-berg wants to merge 1 commit into
jack-berg wants to merge 1 commit into
Conversation
Pull request dashboard statusStatus last refreshed: 2026-07-26 19:38:43 UTC.
This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8654 +/- ##
============================================
- Coverage 91.64% 91.50% -0.15%
- Complexity 10389 10610 +221
============================================
Files 1021 1024 +3
Lines 27379 28025 +646
Branches 3219 3224 +5
============================================
+ Hits 25091 25643 +552
- Misses 1558 1640 +82
- Partials 730 742 +12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #8402.
This PR solves lingering problems with the declarative config generated pojos. With it, all the issues I know of related to the generated POJOs are resolved, unblocking stabilization of declarative config.
*/developmentversion, is will be silently dropped from the parsed model.How it solves these issues:
<Type>ModelAccessorclass inio.opentelemetry.sdk.autoconfigure.declarativeconfig.model.internal. This contains generated, type safe accessors for setting / getting experimental types from the stable parent type.*/developmentversion of its property if available and the stable version is not set.@JsonAnySettermethodwithExtensionProperty(String name, @Nullable Object value)for handling JSON schemaadditionalProperties: trueand experimental properties:nameis equal to a known stable property after stripping/developmentsuffix, log a warning to prefer the stable variant, convertvalueto the stable property type and save it.namecorresponds to known experimental property, convertvalueto the experimental property type and save it.