Skip to content

Remove duplicate declarative config resolver#8579

Merged
jack-berg merged 1 commit into
open-telemetry:mainfrom
Develop-KIM:gh-8569-deduplicate-config-resolver
Jul 10, 2026
Merged

Remove duplicate declarative config resolver#8579
jack-berg merged 1 commit into
open-telemetry:mainfrom
Develop-KIM:gh-8569-deduplicate-config-resolver

Conversation

@Develop-KIM

Copy link
Copy Markdown
Contributor

Changes

Removes the duplicate DeclarativeConfigPropertyUtil::getStringList entry from the declarative config value resolver list.

Rationale

The duplicate resolver is unreachable because resolveValue returns the first non-null value. The resolver list now maps one-to-one to the supported scalar, scalar-list, structured-list, and structured value resolvers.

Closes #8569.

Verification

./gradlew :api:incubator:compileJava :api:incubator:spotlessJavaCheck :api:incubator:checkstyleMain :api:incubator:test

AI assistance was used to draft and validate this change.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jul 9, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: Develop-KIM / name: Develop-KIM (ca18203)

@Develop-KIM
Develop-KIM force-pushed the gh-8569-deduplicate-config-resolver branch from b7a2ed5 to ca18203 Compare July 9, 2026 12:00
@Develop-KIM
Develop-KIM marked this pull request as ready for review July 9, 2026 12:04
@Develop-KIM
Develop-KIM requested a review from a team as a code owner July 9, 2026 12:04
@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.54%. Comparing base (38dfb98) to head (ca18203).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8579   +/-   ##
=========================================
  Coverage     91.54%   91.54%           
  Complexity    10261    10261           
=========================================
  Files          1013     1013           
  Lines         27106    27106           
  Branches       3183     3183           
=========================================
  Hits          24815    24815           
  Misses         1565     1565           
  Partials        726      726           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jack-berg
jack-berg merged commit e29f345 into open-telemetry:main Jul 10, 2026
29 checks passed
@otelbot

otelbot Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution @Develop-KIM! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate getStringList resolver in DeclarativeConfigPropertyUtil

2 participants