Fix serialization of array-valued scope and resource attributes in Prometheus exporter#8497
Merged
jack-berg merged 3 commits intoJul 10, 2026
Conversation
…ometheus exporter
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8497 +/- ##
=========================================
Coverage 91.60% 91.61%
Complexity 10310 10310
=========================================
Files 1013 1013
Lines 27258 27260 +2
Branches 3201 3201
=========================================
+ Hits 24971 24973 +2
Misses 1560 1560
Partials 727 727 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jack-berg
added
the
needs author feedback
thswlsqls
marked this pull request as ready for review
July 4, 2026 09:07
The unfilled ([#XXXX](.../pull/XXXX)) link failed markdown-link-check.
Contributor
Author
|
Ready for review. Removed the placeholder CHANGELOG link that was failing markdown-link-check. |
github-actions
Bot
removed
the
needs author feedback
zeitlinger
approved these changes
Jul 10, 2026
Contributor
|
Thank you for your contribution @thswlsqls! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5987
Description
Otel2PrometheusConverter.convertAttributes(), scope and resource attributes were serialized with rawObject.toString(), so array values became[a, b](no quotes, no escaping) instead of valid JSON.toLabelValue(AttributeType, Object)helper, matching the point-attribute path which already JSON-encodes arrays as["a","b"]. Scalar output (STRING/BOOLEAN/LONG/DOUBLE) is unchanged becausetoLabelValuereturnstoString()for them.Testing done
Otel2PrometheusConverterTest#arrayValuedScopeAttributeSerializedAsJson(scopeotel_scope_*label) and anarray-valued resource attributecase inresourceAttributesAdditionArgs(resource label). Both fail before the fix, pass after../gradlew :exporters:prometheus:check— 192 tests pass (Otel2PrometheusConverterTestgreen; one unrelated flakyPrometheusHttpServerTest.fetch_DuplicateMetricslog-assertion fails intermittently and passes on rerun/in isolation).docs/apidiffsdiff.## Unreleasedentry inCHANGELOG.md.