Update to opentelemetry-configuration v1.1.0#8451
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (27.09%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #8451 +/- ##
============================================
- Coverage 78.76% 78.51% -0.26%
- Complexity 8579 8601 +22
============================================
Files 1009 1013 +4
Lines 28993 29148 +155
Branches 3599 3631 +32
============================================
+ Hits 22836 22885 +49
- Misses 5312 5420 +108
+ Partials 845 843 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jack-berg
changed the title
| /** Reflectively set the max export batch size for the {@link SdkMeterProviderBuilder}. */ | ||
| public static SdkMeterProviderBuilder setMaxExportBatchSize( | ||
| SdkMeterProviderBuilder sdkMeterProviderBuilder, int maxExportBatchSize) { | ||
| public static PeriodicMetricReaderBuilder setMaxExportBatchSize( |
There was a problem hiding this comment.
This was wrong. Had to fix to add support for the new declarative config property for configuring batch size.
|
|
||
| @Override | ||
| public String getName() { | ||
| return "event_to_span_event_bridge/development"; |
There was a problem hiding this comment.
Now that event_to_span_event_bridge is formally supported in declarative config, we can directly reference instance of using SPI.
| * The attribute value. The type of value must match .type. Property is required and must be | ||
| * non-null. | ||
| * The attribute value. The type of value must match .type. Property must be present, but if null | ||
| * the entry is ignored. |
There was a problem hiding this comment.
With POJOs checked into VCS now, its cool /useful to see these diffs as we update to the new version of the schema
| @JsonPropertyOrder({}) | ||
| @Generated("jsonschema2pojo") | ||
| @SuppressWarnings({"NullAway", "rawtypes", "BoxedPrimitiveEquality"}) | ||
| public class ExperimentalEventToSpanEventBridgeLogRecordProcessorModel { |
There was a problem hiding this comment.
there's no content in this guy? Just an empty class for now?
There was a problem hiding this comment.
Yup - some types don't have any configurable properties. Things like AlwayOnSampler, AlwaysOffSampler, ConsoleExporter. Specifying their key is enough to opt in, and if they ever gain configurable properties they'll be added to the type. Example:
file_format: "1.1"
tracer_provider:
processors:
event_to_span_event_bridge/development:
batch:
exporter:
otlp_http:
endpoint: http://localhost:4318/v1/spans
sampler:
always_on:
2 participants
Release notes: https://github.com/open-telemetry/opentelemetry-configuration/releases/tag/v1.1.0