Change GlobUtil, IncludeExcludePredicate to use case sensitive matching consistently#8152
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8152 +/- ##
=========================================
Coverage 90.29% 90.29%
+ Complexity 7650 7649 -1
=========================================
Files 843 843
Lines 23059 23059
Branches 2309 2309
=========================================
+ Hits 20821 20822 +1
+ Misses 1519 1518 -1
Partials 719 719 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
do we need also to include |
Member
Author
Pushed a commit to extend to GlobUtil, but this definitely widens the scope of impact, since metric view name selection is impacted. I still characterize this as a bug fix, since as GlobUtilTest updates show, the pattern matching portion of was still case sensitive despite the exact match being case insensitive. One way or the other, we have to make it consistent, and I see no language in the spec to suggest that view metric name matching, glob patterns, or matching in general should be case insensitive. |
jack-berg
changed the title
trask
approved these changes
Mar 6, 2026
Member
👍 |
jack-berg
added a commit
that referenced
this pull request
Mar 6, 2026
jack-berg
added a commit
that referenced
this pull request
Mar 6, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Mar 6, 2026
…ng consistently (#8152)
eamonn-kearns-ibm
added a commit
to eamonn-kearns-ibm/opentelemetry-java
that referenced
this pull request
Apr 1, 2026
* [release/v1.60.x] Prepare release 1.60.0 (open-telemetry#8151) Co-authored-by: otelbot <[email protected]> * Add changelog entry for open-telemetry#8152 to 1.60.x release branch (open-telemetry#8154) * [release/v1.60.x] Change GlobUtil, IncludeExcludePredicate to use case sensitive matching consistently (open-telemetry#8155) Co-authored-by: Jack Berg <[email protected]> * [release/v1.60.x] Fix warning always emitted (open-telemetry#8158) Co-authored-by: Trask Stalnaker <[email protected]> * Prepare changelog for 1.60.1 (open-telemetry#8160) * [release/v1.60.x] Prepare release 1.60.1 (open-telemetry#8161) Co-authored-by: otelbot <[email protected]> * initial commit * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md --------- Co-authored-by: otelbot[bot] <197425009+otelbot[bot]@users.noreply.github.com> Co-authored-by: otelbot <[email protected]> Co-authored-by: Jack Berg <[email protected]> Co-authored-by: Trask Stalnaker <[email protected]>
eamonn-kearns-ibm
added a commit
to eamonn-kearns-ibm/opentelemetry-java
that referenced
this pull request
Apr 2, 2026
* [release/v1.60.x] Prepare release 1.60.0 (open-telemetry#8151) Co-authored-by: otelbot <[email protected]> * Add changelog entry for open-telemetry#8152 to 1.60.x release branch (open-telemetry#8154) * [release/v1.60.x] Change GlobUtil, IncludeExcludePredicate to use case sensitive matching consistently (open-telemetry#8155) Co-authored-by: Jack Berg <[email protected]> * [release/v1.60.x] Fix warning always emitted (open-telemetry#8158) Co-authored-by: Trask Stalnaker <[email protected]> * Prepare changelog for 1.60.1 (open-telemetry#8160) * [release/v1.60.x] Prepare release 1.60.1 (open-telemetry#8161) Co-authored-by: otelbot <[email protected]> * initial commit * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md --------- Co-authored-by: otelbot[bot] <197425009+otelbot[bot]@users.noreply.github.com> Co-authored-by: otelbot <[email protected]> Co-authored-by: Jack Berg <[email protected]> Co-authored-by: Trask Stalnaker <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8137.