Capture context class loader during async callback registration#8091
Merged
jack-berg merged 1 commit intoMar 16, 2026
Merged
Conversation
trask
commented
Feb 15, 2026
| private final Runnable callback; | ||
| private final List<InstrumentDescriptor> instrumentDescriptors; | ||
| private final boolean hasStorages; | ||
| @Nullable private final ClassLoader contextClassLoader; |
Member
Author
There was a problem hiding this comment.
I think strong ref to the context class loader here is ok, given that we already have a strong ref to the callback's class loader
could make it a weakref, but not sure there's a foolproof behavior when it gets cleared
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8091 +/- ##
=========================================
Coverage 90.21% 90.22%
- Complexity 7605 7606 +1
=========================================
Files 841 841
Lines 22923 22928 +5
Branches 2291 2291
=========================================
+ Hits 20681 20687 +6
Misses 1525 1525
+ Partials 717 716 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
trask
marked this pull request as ready for review
February 15, 2026 00:44
jack-berg
approved these changes
Mar 16, 2026
jack-berg
left a comment
jack-berg
left a comment
Member
There was a problem hiding this comment.
This looks good. Sorry it took me a bit to get to.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5694
Also probably would have avoided the breakage @brunobat reported in #7488 (comment).