Change ConfigProvider.getInstrumentationConfig() to not return null#7920
Change ConfigProvider.getInstrumentationConfig() to not return null#7920trask wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
trask
force-pushed
the
get-instrumentation-config
branch
from
ec0e1d7 to
95652e8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7920 +/- ##
=========================================
Coverage 90.11% 90.11%
- Complexity 7318 7319 +1
=========================================
Files 824 824
Lines 22027 22030 +3
Branches 2177 2177
=========================================
+ Hits 19850 19853 +3
Misses 1500 1500
Partials 677 677 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks like this is against spec language https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/configuration/api.md#get-instrumentation-config
|
|
Closing because #7954 was a duplicate of this, but somehow got merged first |
|
I didn't see that we already had a PR for this |
3 participants
null-checking this all the time is awkward
This was being used to detect whether in declarative configuration world or not, but I think instrumentations can still be split brained if they really want to by first looking for the specific declarative configuration they care about and falling back to system properties.
cc @zeitlinger