Don't allow this to escape constructor
#7785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7785 +/- ##
=========================================
Coverage 90.17% 90.17%
Complexity 7189 7189
=========================================
Files 814 814
Lines 21730 21724 -6
Branches 2129 2129
=========================================
- Hits 19594 19590 -4
+ Misses 1467 1465 -2
Partials 669 669 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
anuraaga
approved these changes
Oct 23, 2025
jack-berg
approved these changes
Oct 24, 2025
Merged
the-clam
pushed a commit
to the-clam/opentelemetry-java
that referenced
this pull request
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/open-telemetry/opentelemetry-java/pull/7784/files#r2453708480
Alternatively, I can suppress the warning, but this PR seems like an overall simplification.