Skip to content

Conversation

@trask
Copy link
Member

@trask trask commented Oct 22, 2025

Currently built on top of #7780

Motivated by #7779

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.18%. Comparing base (2a0ad44) to head (f456785).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7784   +/-   ##
=========================================
  Coverage     90.17%   90.18%           
- Complexity     7190     7191    +1     
=========================================
  Files           814      814           
  Lines         21724    21724           
  Branches       2129     2129           
=========================================
+ Hits          19589    19591    +2     
+ Misses         1467     1466    -1     
+ Partials        668      667    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines +91 to +92
"-Xlint:-serial",
"-Xlint:-this-escape",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved in #7785

// target.
java {
toolchain {
languageVersion.set(JavaLanguageVersion.of(17))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it no longer relevant to set the java language version for the build of buildSrc?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, other repos don't

@trask trask marked this pull request as ready for review October 24, 2025 17:47
@trask trask requested a review from a team as a code owner October 24, 2025 17:47
@jack-berg jack-berg merged commit d5829cf into open-telemetry:main Oct 24, 2025
29 checks passed
the-clam pushed a commit to the-clam/opentelemetry-java that referenced this pull request Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants