Spec update: Changes to disabled config must be eventually visible #7706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7706 +/- ##
============================================
+ Coverage 90.12% 90.15% +0.02%
- Complexity 7187 7189 +2
============================================
Files 814 814
Lines 21700 21702 +2
Branches 2123 2125 +2
============================================
+ Hits 19557 19565 +8
+ Misses 1477 1472 -5
+ Partials 666 665 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jkwatson
approved these changes
Sep 25, 2025
Contributor
jkwatson
left a comment
jkwatson
left a comment
There was a problem hiding this comment.
i'm fine with this change.
Member
|
Can we discuss this before merging? #7700 (comment) Thanks! |
jack-berg
approved these changes
Sep 29, 2025
Member
jack-berg
left a comment
jack-berg
left a comment
There was a problem hiding this comment.
Should make this to relevant places for SdkTracer, SdkMeter (and MetricStorage impls), but I'm happy with now that I see that it only adds ~.8ns / operation
…e implementations Co-authored-by: trask <[email protected]>
…-10ae5da2915a Make enabled fields volatile in SdkTracer, SdkMeter, and MetricStorage implementations
Member
Author
done |
the-clam
pushed a commit
to the-clam/opentelemetry-java
that referenced
this pull request
Nov 6, 2025
…pen-telemetry#7706) Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: trask <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements open-telemetry/opentelemetry-specification#4645
See benchmarks in #7700