return resource in auto configured sdk #7639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7639 +/- ##
============================================
+ Coverage 90.13% 90.16% +0.03%
- Complexity 7192 7195 +3
============================================
Files 814 814
Lines 21713 21719 +6
Branches 2127 2125 -2
============================================
+ Hits 19570 19583 +13
+ Misses 1477 1471 -6
+ Partials 666 665 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zeitlinger
force-pushed
the
declarative-config-return-resource
branch
from
1b36c6e to
5f388fb
Compare
jack-berg
reviewed
Sep 24, 2025
Member
jack-berg
left a comment
jack-berg
left a comment
There was a problem hiding this comment.
Just a couple of minor comments but I think this is a decent way to proceed.
...xtensions/autoconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/IncubatingUtil.java
Outdated
Show resolved
Hide resolved
...o/opentelemetry/sdk/extension/incubator/fileconfig/AutoConfiguredOpenTelemetrySdkAccess.java
Outdated
Show resolved
Hide resolved
zeitlinger
force-pushed
the
declarative-config-return-resource
branch
from
5f388fb to
16e1492
Compare
Member
Author
|
@jack-berg please check again |
robsunday
reviewed
Sep 25, 2025
.../main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/DeclarativeConfigContext.java
Show resolved
Hide resolved
robsunday
approved these changes
Sep 26, 2025
Contributor
robsunday
left a comment
robsunday
left a comment
There was a problem hiding this comment.
Solution works perfectly and I can access resource attributes in my BeforeAgentListener implementations
jack-berg
reviewed
Sep 26, 2025
.../main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/DeclarativeConfigContext.java
Show resolved
Hide resolved
jack-berg
approved these changes
Sep 26, 2025
Member
Author
|
@jack-berg can this be merged? |
the-clam
pushed a commit
to the-clam/opentelemetry-java
that referenced
this pull request
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #7418 that
AutoConfiguredOpenTelemetrySdkFixes open-telemetry/opentelemetry-java-instrumentation#14325