Skip to content

Update okhttp dependency to okhttp-jvm #7517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkwatson merged 3 commits into from
Jul 29, 2025
Merged

Update okhttp dependency to okhttp-jvm #7517

jkwatson merged 3 commits into from
Jul 29, 2025

Conversation

@jaydeluca
Copy link
Member

@jaydeluca jaydeluca commented Jul 28, 2025

This hopefully resolves #7491

I ended up having to change dependencyManagement/build.gradle.kts because I was getting errors seeming to indicate the BOM wasn't working for the okhttp-jvm package.

I was getting:

* What went wrong:
Execution failed for task ':exporters:sender:okhttp:compileJava'.
> Could not resolve all files for configuration ':exporters:sender:okhttp:compileClasspath'.
   > Could not find com.squareup.okhttp3:okhttp-jvm:.
     Required by:
         project :exporters:sender:okhttp

If there's a different way to handle that so we don't have to list out the bom and the okhttp-jvm dependencies in dependencyManagement/build.gradle.kts separately, let me know

@jaydeluca jaydeluca requested a review from a team as a code owner July 28, 2025 16:24
@codecov
Copy link

codecov bot commented Jul 28, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.00%. Comparing base (17b4065) to head (13196c7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #7517   +/-   ##
=========================================
  Coverage     90.00%   90.00%           
  Complexity     7079     7079           
=========================================
  Files           803      803           
  Lines         21405    21405           
  Branches       2086     2086           
=========================================
  Hits          19266    19266           
  Misses         1477     1477           
  Partials        662      662

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jkwatson
jkwatson approved these changes Jul 28, 2025
View reviewed changes
Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkwatson jkwatson merged commit ff4d326 into open-telemetry:main Jul 29, 2025
29 checks passed
@trask trask mentioned this pull request Aug 12, 2025
Closed
@cbruegg cbruegg mentioned this pull request Sep 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkwatson jkwatson jkwatson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

opentelemetry-exporter-sender-okhttp:1.52.0 consumed in Maven based applications fails due to missing OkHttp classes

2 participants

@jaydeluca @jkwatson