Update to declarative config 1.0-rc.1 #7436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-berg
commented
Jun 20, 2025
| import io.opentelemetry.sdk.resources.Resource; | ||
| import java.util.Collections; | ||
|
|
||
| public class ServiceResourceDetector implements ComponentProvider<Resource> { |
Member
Author
There was a problem hiding this comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7436 +/- ##
=========================================
Coverage 89.75% 89.75%
- Complexity 6980 6987 +7
=========================================
Files 797 798 +1
Lines 21165 21181 +16
Branches 2057 2058 +1
=========================================
+ Hits 18996 19012 +16
Misses 1505 1505
Partials 664 664 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jsuereth
approved these changes
Jun 20, 2025
jack-berg
commented
Jun 23, 2025
...c/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/ServiceResourceDetector.java
Outdated
Show resolved
Hide resolved
breedx-splk
reviewed
Jun 23, 2025
.../opentelemetry/sdk/extension/incubator/fileconfig/OpenTelemetryConfigurationFactoryTest.java
Show resolved
Hide resolved
breedx-splk
approved these changes
Jun 23, 2025
Contributor
breedx-splk
left a comment
breedx-splk
left a comment
There was a problem hiding this comment.
One small idea, but LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes here: https://github.com/open-telemetry/opentelemetry-configuration/releases/tag/v1.0.0-rc.1
Users of 0.4 should not be impacted as this release consists of only a small set of backwards compatible changes.