Remove scope info, always add scope labels #7398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7398 +/- ##
============================================
- Coverage 89.99% 89.98% -0.02%
+ Complexity 7080 7070 -10
============================================
Files 803 803
Lines 21412 21394 -18
Branches 2086 2081 -5
============================================
- Hits 19270 19251 -19
- Misses 1479 1480 +1
Partials 663 663 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jack-berg
reviewed
Jun 20, 2025
Member
jack-berg
left a comment
jack-berg
left a comment
There was a problem hiding this comment.
Nice approach! Few minor comments, but I think we should aim to merge.
.../prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java
Outdated
Show resolved
Hide resolved
exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/OtelScopeMode.java
Outdated
Show resolved
Hide resolved
.../prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java
Outdated
Show resolved
Hide resolved
...metheus/src/test/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverterTest.java
Show resolved
Hide resolved
...metheus/src/test/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverterTest.java
Show resolved
Hide resolved
zeitlinger
force-pushed
the
remove-scope-info
branch
from
3cc588e to
7d7dd89
Compare
zeitlinger
force-pushed
the
remove-scope-info
branch
from
7d7dd89 to
4d3eaaa
Compare
Member
Author
|
@jack-berg please check again |
trask
reviewed
Aug 4, 2025
...rs/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/PrometheusMetricReader.java
Outdated
Show resolved
Hide resolved
...src/main/java/io/opentelemetry/exporter/prometheus/internal/PrometheusComponentProvider.java
Outdated
Show resolved
Hide resolved
zeitlinger
force-pushed
the
remove-scope-info
branch
2 times, most recently
from
dac6a0c to
340dff3
Compare
trask
reviewed
Aug 12, 2025
exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/OtelScopeMode.java
Outdated
Show resolved
Hide resolved
.../prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java
Outdated
Show resolved
Hide resolved
.../prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java
Show resolved
Hide resolved
.../prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java
Show resolved
Hide resolved
exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/OtelScopeMode.java
Outdated
Show resolved
Hide resolved
zeitlinger
changed the title
zeitlinger
force-pushed
the
remove-scope-info
branch
from
340dff3 to
8f2e5b6
Compare
Member
Author
|
@trask please check again |
trask
reviewed
Aug 19, 2025
exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/OtelScopeMode.java
Outdated
Show resolved
Hide resolved
zeitlinger
commented
Aug 20, 2025
...src/main/java/io/opentelemetry/exporter/prometheus/internal/PrometheusComponentProvider.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Aug 20, 2025
.../prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java
Show resolved
Hide resolved
...ometheus/src/main/java/io/opentelemetry/exporter/prometheus/PrometheusHttpServerBuilder.java
Outdated
Show resolved
Hide resolved
Member
Author
|
Just discussed this with @ArthurSens We want to remove the |
…rometheus/internal/PrometheusComponentProvider.java Co-authored-by: Trask Stalnaker <[email protected]>
zeitlinger
force-pushed
the
remove-scope-info
branch
from
6978a3b to
50b9b3c
Compare
jaydeluca
approved these changes
Sep 5, 2025
Member
jaydeluca
left a comment
jaydeluca
left a comment
There was a problem hiding this comment.
I think the description of this PR needs to be updated? Something like "Remove scope info, always add scope labels"
zeitlinger
changed the title
jkwatson
approved these changes
Sep 9, 2025
Member
Author
|
@jkwatson can this be merged? |
the-clam
pushed a commit
to the-clam/opentelemetry-java
that referenced
this pull request
Nov 6, 2025
Co-authored-by: Trask Stalnaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #7356
Spec issue: open-telemetry/opentelemetry-specification#4634