Skip to content

fix(httpclient): ensure proper closure of HttpClient in shutdown method #7390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jack-berg merged 2 commits into from
Jun 9, 2025
Merged

fix(httpclient): ensure proper closure of HttpClient in shutdown method #7390

jack-berg merged 2 commits into from
Jun 9, 2025

Conversation

@felixbarny
Copy link
Contributor

@felixbarny felixbarny commented Jun 5, 2025

Fixes #7388

@felixbarny felixbarny requested a review from a team as a code owner June 5, 2025 09:20
@felixbarny felixbarny mentioned this pull request Jun 5, 2025
Closed
@codecov
Copy link

codecov bot commented Jun 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.79%. Comparing base (a756317) to head (7fc53da).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
...ry/exporter/sender/jdk/internal/JdkHttpSender.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #7390      +/-   ##
============================================
- Coverage     89.79%   89.79%   -0.01%     
  Complexity     6969     6969              
============================================
  Files           795      795              
  Lines         21122    21127       +5     
  Branches       2056     2057       +1     
============================================
+ Hits          18967    18971       +4     
  Misses         1495     1495              
- Partials        660      661       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jack-berg
jack-berg approved these changes Jun 9, 2025
View reviewed changes
Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - thanks!

@jack-berg jack-berg merged commit 6a164a9 into open-telemetry:main Jun 9, 2025
28 checks passed
@felixbarny felixbarny deleted the close-httpclient branch June 10, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jack-berg jack-berg jack-berg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JdkHttpSender leaks SelectorManager thread

2 participants

@felixbarny @jack-berg