fixbug 修复io.opentelemetry.api.incubator.propagation.CaseInsensitiveMap#6524
fixbug 修复io.opentelemetry.api.incubator.propagation.CaseInsensitiveMap#6524junwense wants to merge 15 commits intoopen-telemetry:mainfrom
Conversation
Copilot translated this from Chinese to English: "I discovered this issue while testing the HttpServer in io.opentelemetry.examples.http from io.opentelemetry.example.http. It causes the trace sent from the client to the server to break. Because the case of the headers changes when transmitted via HTTP, the server needs to convert the key in this map to lowercase to retrieve the traceparent information. However, constructing this map through the constructor causes the keys in this method to not be all lowercase." |
|
@junwense build failure was caused by formatting. Please run |
|
@junwense two things:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6524 +/- ##
============================================
- Coverage 90.63% 90.62% -0.02%
- Complexity 6228 6261 +33
============================================
Files 679 689 +10
Lines 18661 18704 +43
Branches 1842 1844 +2
============================================
+ Hits 16914 16950 +36
- Misses 1189 1198 +9
+ Partials 558 556 -2 ☔ View full report in Codecov by Sentry. |
…pagation/CaseInsensitiveMapTest.java
我于测试io.opentelemetry.examples.http 的io.opentelemetry.example.http.HttpServer 发现此问题,会导致客户端发送到服务端的trace断裂,因为通过http传输,header里面的大小写会变化,所以服务端需要根据此map把key转换成小写获取traceparent的信息,但是通过构造函数构造此map,会导致此方法里的key不是全部小写。