Completable result code throwable#6348
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6348 +/- ##
=========================================
Coverage 90.17% 90.17%
- Complexity 6259 6269 +10
=========================================
Files 697 697
Lines 18871 18890 +19
Branches 1843 1844 +1
=========================================
+ Hits 17016 17035 +19
Misses 1283 1283
Partials 572 572 ☔ View full report in Codecov by Sentry. |
|
Hi @jack-berg any updates on when this might be merged? I'd be happy to look into contributing with PRs to update the Http and Grpc exporters once this is merged (as discussed #6306 (comment)). Thanks. |
|
@jarrodrobins - I'm blocked on reviews / approvals from @open-telemetry/java-approvers. I review from you is helpful as well, but won't be able to merge without an approval from an approver. |
jkwatson
left a comment
jkwatson
left a comment
There was a problem hiding this comment.
I'm not in love with the "getFailureThrowable" name, but I can't think of anything better that would be as clear. (I was thinking about "getFailureReason", but that seems too general).
🚢
…y-java into completable-result-code-throwable
4 participants
Related to #6306.
Discussed in the 3/28/24 Java SIG. Also need to adjust the behavior of HttpExporter and GrpcExporter (and potentially the related sender implementations) to fail CompletableResultCodes exceptionally. Planning on doing this in a followup PR, since there are details to work out about what the structure is with the failure exception.