Add toBuilder() at PrometheusHttpServer#6333
Merged
jack-berg merged 2 commits intoopen-telemetry:mainfrom Apr 3, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6333 +/- ##
============================================
+ Coverage 91.07% 91.11% +0.03%
- Complexity 5751 5760 +9
============================================
Files 626 627 +1
Lines 16782 16800 +18
Branches 1718 1718
============================================
+ Hits 15285 15308 +23
+ Misses 1003 998 -5
Partials 494 494 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@jack-berg Can you review? |
jack-berg
reviewed
Apr 2, 2024
jack-berg
approved these changes
Apr 2, 2024
…rometheus/PrometheusHttpServerTest.java Co-authored-by: jack-berg <[email protected]>
57 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the conventions we have in the code, I've added the ability to create create a
PrometheusHttpServerBuilderout of an existingPrometheusHttpServer.This is particularly useful if you use
AutoConfiguredOpenTelemetrySdkBuilder.addMetricReaderCustomizer(). In that method, you are given aMetricReaderinstance. In the case ofPrometheusHttpServeryou need to cast it toPrometheusHttpServerand then you can use the newtoBuilder()to modify it.This is a the completion step for (1) #6179 and (2) #6231