Rename opentelemetry-extension-incubator to opentelemetry-api-incubator, merge opentelemetry-api-events#6289
Conversation
|
|
||
| description = "OpenTelemetry API Incubator" | ||
| otelJava.moduleName.set("io.opentelemetry.extension.incubator") | ||
| otelJava.moduleName.set("io.opentelemetry.api.incubator") |
There was a problem hiding this comment.
The package changes as well.
|
I considered making an equivalent change to rename |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6289 +/- ##
============================================
+ Coverage 91.04% 91.06% +0.02%
- Complexity 5726 5729 +3
============================================
Files 625 625
Lines 16744 16744
Branches 1713 1713
============================================
+ Hits 15244 15248 +4
+ Misses 1006 1003 -3
+ Partials 494 493 -1 ☔ View full report in Codecov by Sentry. |
|
FYI, if we can't get this PR and a followup to be able to define event payloads in the log record body in time for the next release, I think we need to revert #6253. |
breedx-splk
left a comment
breedx-splk
left a comment
There was a problem hiding this comment.
Yeah, I support this. Sorry about the delay in getting it rubber stamped....kubecon timing is a little tricky. I hope we can still get the remaining event stuff in! 🤞🏻
|
@open-telemetry/java-approvers I'll merge this tomorrow if there are no additional comments. Need to keep moving on this to bundle all the changes w/ churn in time for the next release. |
2 participants
Resolves #6121. Summary of changes:
io.opentelemetry:opentelemetry-extension-incubatortoio.opentelemetry:opentelemetry-api-incubatorio.opentelemetry.extension.incubator.*toio.opentelemetry.api.incubatorio.opentelemetry:opentelemetry-api-event. Merge contents intoio.opentelemetry:opentelemetry-api-incubator.io.opentelemetry.api.eventstoio.opentelemetry.api.incubator.eventsPart of the goal of bundling several breaking changes into a single release to reduce churn.
cc @breedx-splk