Added MetricReader customizer for AutoConfiguredOpenTelemetrySdkBuilder#6231
Conversation
|
This is the second step for #6179, since without you currently won't be able to modify a Prometheus reader created by |
|
@jack-berg This is the 2nd step required for me to use it in Apache Pulsar. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6231 +/- ##
=========================================
Coverage 91.06% 91.06%
- Complexity 5695 5699 +4
=========================================
Files 621 621
Lines 16667 16679 +12
Branches 1707 1709 +2
=========================================
+ Hits 15177 15188 +11
- Misses 997 998 +1
Partials 493 493 ☔ View full report in Codecov by Sentry. |
|
@jack-berg Fixed all comments. |
jack-berg
left a comment
There was a problem hiding this comment.
Just one last comment about a possible extra dependency.
|
@jack-berg Fixed |
Added an ability to customize a
MetricReadercreated atAutoConfiguredOpenTelemetrySdkBuilderby allowing to specify a BiFunction which accepts aMetricReaderand the configuration and returns aMetricReader. This allows the user to create a new MetricReader either based on the one created byAutoConfiguredOpenTelemetrySdkBuilderor a completely new one.