Identifying otel http calls#5918
Merged
jack-berg merged 24 commits intoopen-telemetry:mainfrom Nov 9, 2023
Merged
Conversation
Codecov ReportAttention:
... and 33 files with indirect coverage changes 📢 Thoughts on this report? Let us know! |
breedx-splk
approved these changes
Oct 25, 2023
Contributor
breedx-splk
left a comment
breedx-splk
left a comment
There was a problem hiding this comment.
Yeah this is a cool addition that will benefit Android. Thanks!
jack-berg
reviewed
Nov 3, 2023
jack-berg
reviewed
Nov 3, 2023
jack-berg
reviewed
Nov 3, 2023
jack-berg
reviewed
Nov 3, 2023
jack-berg
reviewed
Nov 3, 2023
jack-berg
reviewed
Nov 3, 2023
jack-berg
reviewed
Nov 3, 2023
…nal/InstrumentationUtil.java Co-authored-by: jack-berg <[email protected]>
…nal/InstrumentationUtil.java Co-authored-by: jack-berg <[email protected]>
…r/sender/okhttp/internal/OkHttpHttpSenderTest.java Co-authored-by: jack-berg <[email protected]>
…r/sender/okhttp/internal/OkHttpGrpcSenderTest.java Co-authored-by: jack-berg <[email protected]>
jack-berg
reviewed
Nov 7, 2023
jack-berg
reviewed
Nov 7, 2023
Member
|
Just want to get confirmation from @open-telemetry/java-instrumentation-maintainers that this strategy in core will allow instrumentation to accomplish the required suppression? A 👍 on this comment would be great. |
Member
|
@LikeTheSalad can you open an issue to track adding suppression to the other exporters? Zipkin, grpc sender, and jaeger come to mind. |
…mmaryJavadoc" style warning
This was referenced Nov 8, 2023
Contributor
Author
Sure, I've created 2 issues, one for Zipkin and the other for Jaeger:
I'm not sure if I might be missing something but I believe the changes in this PR should cover the grpc sender? |
trask
approved these changes
Nov 8, 2023
jack-berg
approved these changes
Nov 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on comments in the previous Java SIG meeting, I've created this approach to suppress automatic instrumentation using a Context key as it's done for Python.