Skip to content

Stabilize explicit bucket boundaries advice API#5897

Merged
jack-berg merged 3 commits into
open-telemetry:mainfrom
jack-berg:stabilize-bucket-boundary-advice
Nov 6, 2023
Merged

Stabilize explicit bucket boundaries advice API#5897
jack-berg merged 3 commits into
open-telemetry:mainfrom
jack-berg:stabilize-bucket-boundary-advice

Conversation

@jack-berg

@jack-berg jack-berg commented Oct 10, 2023

Copy link
Copy Markdown
Member

Followup to #5848.

The explicit bucket boundaries advice API is now stable: open-telemetry/opentelemetry-specification#3694

@jack-berg
jack-berg requested a review from a team October 10, 2023 16:39
@codecov

codecov Bot commented Oct 10, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...ubator/metrics/ExtendedDoubleHistogramBuilder.java 0.00% <ø> (ø)
...ncubator/metrics/ExtendedLongHistogramBuilder.java 0.00% <ø> (ø)
.../opentelemetry/sdk/metrics/SdkDoubleHistogram.java 97.14% <100.00%> (+0.59%) ⬆️
...io/opentelemetry/sdk/metrics/SdkLongHistogram.java 97.36% <100.00%> (+0.39%) ⬆️
...ernal/aggregator/ExplicitBucketHistogramUtils.java 100.00% <100.00%> (ø)
...ntelemetry/api/metrics/DoubleHistogramBuilder.java 0.00% <0.00%> (ø)
...pentelemetry/api/metrics/LongHistogramBuilder.java 0.00% <0.00%> (ø)

📢 Thoughts on this report? Let us know!.

breedx-splk
breedx-splk reviewed Oct 10, 2023
View reviewed changes
Comment thread api/all/src/main/java/io/opentelemetry/api/metrics/DoubleHistogramBuilder.java
Comment thread sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/SdkDoubleHistogram.java Outdated
@jack-berg

jack-berg commented Oct 31, 2023

Copy link
Copy Markdown
Member Author

If there is no additional feedback I'll merge this tomorrow.

@jack-berg jack-berg added this to the 1.32.0 milestone Nov 3, 2023
@jack-berg
jack-berg merged commit 19196a0 into open-telemetry:main Nov 6, 2023
@nluk

nluk commented Nov 7, 2023 •
edited
Loading

Copy link
Copy Markdown

@mateuszrzeszutek Does this work outside of (AutoConfigured)OpenTelemetrySdk + instanceof check? The instrumentation agent setups an OpenTelemetry instance that provides this builder. It doesn't expose/implement the interface, and there's no handle to get the agentBuilder field to configure it there.

@trask

trask commented Nov 7, 2023

Copy link
Copy Markdown
Member

hi @nluk! oh yes, I believe support for this will need to be added in the OpenTelemetry API bridge that the instrumentation agent uses. can you open an issue for this at https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues?

@nluk nluk mentioned this pull request Nov 15, 2023
Closed
@knbk knbk mentioned this pull request Dec 6, 2023
Closed
@coderabbitai coderabbitai Bot mentioned this pull request May 7, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trask trask trask left review comments
@breedx-splk breedx-splk breedx-splk left review comments
+1 more reviewer
@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.32.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jack-berg @nluk @trask @mateuszrzeszutek @breedx-splk