Promote log API / SDK to stable#5341
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5341 +/- ##
============================================
- Coverage 91.29% 91.29% -0.01%
+ Complexity 4890 4887 -3
============================================
Files 549 548 -1
Lines 14406 14404 -2
Branches 1354 1353 -1
============================================
- Hits 13152 13150 -2
Misses 867 867
Partials 387 387
☔ View full report in Codecov by Sentry. |
|
Should |
|
Yes. Additionally the otlp logs exporter module should be merged into the general otlp artifact. Also, auto configuration should be updated to enable otlp by default for the log SDK. Was planning on doing these tasks in separate PRs but happy to do all in one place if helpful. |
separate PRs are no problem, I had missed the tracking issue #5340, thx |
| +++ NEW METHOD: PUBLIC(+) ABSTRACT(+) io.opentelemetry.api.logs.LogRecordBuilder setTimestamp(java.time.Instant) | ||
| +++ NEW ENUM: PUBLIC(+) FINAL(+) io.opentelemetry.api.logs.Severity (compatible) | ||
| +++ CLASS FILE FORMAT VERSION: 52.0 <- n.a. | ||
| +++ NEW INTERFACE: java.lang.constant.Constable |
There was a problem hiding this comment.
That's a Java 12 interface, is this supposed to be here?
There was a problem hiding this comment.
it all depends on the JDK that's being used to generate the api diffs... as long as we're all ok with using java 17, then this will always show up.
There was a problem hiding this comment.
What I don't understand is why this doesn't get generated from other enums in our public API. We have the build check that ensures that there are no uncomitted japicmp changes, and that passes for builds in all the java versions. 🤔
4 participants
Related to #5340. Draft for now until spec stabilizes.