Introduce mTLS support for JaegerRemoteSamplerBuilder (#5209)#5248
Merged
jack-berg merged 1 commit intoopen-telemetry:mainfrom Mar 9, 2023
chicobento:main
Merged
Introduce mTLS support for JaegerRemoteSamplerBuilder (#5209)#5248jack-berg merged 1 commit intoopen-telemetry:mainfrom chicobento:main
jack-berg merged 1 commit intoopen-telemetry:mainfrom
chicobento:main
Conversation
|
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5248 +/- ##
============================================
+ Coverage 90.93% 90.96% +0.03%
- Complexity 4887 4890 +3
============================================
Files 551 551
Lines 14468 14470 +2
Branches 1372 1372
============================================
+ Hits 13156 13163 +7
+ Misses 914 908 -6
- Partials 398 399 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jack-berg
approved these changes
Feb 24, 2023
Member
jack-berg
left a comment
jack-berg
left a comment
There was a problem hiding this comment.
Seems reasonable to me. Thanks!
Member
|
@chicobento can you sign the CLA? |
Contributor
Author
|
@jack-berg done |
Contributor
Author
|
@jack-berg , just rebased and resolved the conflicts |
Member
|
Thanks @chicobento! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.