Fixed example resource provider fully qualified class name#5235
Fixed example resource provider fully qualified class name#5235jkwatson merged 1 commit intoopen-telemetry:mainfrom cheempz:main
Conversation
|
|
Codecov ReportBase: 91.08% // Head: 91.08% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #5235 +/- ##
=========================================
Coverage 91.08% 91.08%
Complexity 4876 4876
=========================================
Files 549 549
Lines 14421 14421
Branches 1372 1372
=========================================
Hits 13136 13136
Misses 891 891
Partials 394 394 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
|
||
| ``` | ||
| -Dotel.java.disabled.resource.providers=io.opentelemetry.sdk.extension.resources.OsResourceProvider | ||
| -Dotel.java.disabled.resource.providers=io.opentelemetry.instrumentation.resources.OsResourceProvider |
There was a problem hiding this comment.
hrm. maybe we should remove this example altogether, since it depends on the instrumentation repository. 🤔
There was a problem hiding this comment.
Hmm, well the section is prefaced with
If you are using the
ResourceProviderSPI (many instrumentation agent distributions include this automatically)
and the example did help me eventually find my way heh, but happy to just remove it too to reduce confusion.
|
@cheempz we can't accept this PR until the CLA has been signed. |
|
OK not-so-EasyCLA finally worked after several tries. |
2 participants
Related to #4748, updated to the new package name.