Stop ignoring long measurements in HistogramExemplarReservoir#5216
Merged
jack-berg merged 1 commit intoopen-telemetry:mainfrom Feb 15, 2023
Merged
Conversation
Codecov ReportBase: 91.08% // Head: 91.09% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #5216 +/- ##
=========================================
Coverage 91.08% 91.09%
Complexity 4875 4875
=========================================
Files 549 549
Lines 14418 14420 +2
Branches 1372 1372
=========================================
+ Hits 13133 13136 +3
Misses 891 891
+ Partials 394 393 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jkwatson
approved these changes
Feb 15, 2023
mateuszrzeszutek
approved these changes
Feb 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted by @dashpole here there's a bug in the
HistogramExemplarReservoirimplementation.HistogramPointData only supports double exemplars. Despite our API supporting both
LongHistogramandDoubleHistogram, long values are simply converted to doubles in the aggregator. However, theHistogramExemplarReservoirdidn't get the memo and reports a value of0.0when any long measurement is recorded as an exemplar.This fixes the issue by casting long measurements to double before storing in the reservoir.