Make closing scope idempotent and noop when different context is active#5061
Merged
jack-berg merged 3 commits intoopen-telemetry:mainfrom Dec 29, 2022
Merged
Conversation
Codecov ReportBase: 91.22% // Head: 91.22% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #5061 +/- ##
=========================================
Coverage 91.22% 91.22%
- Complexity 4877 4881 +4
=========================================
Files 553 553
Lines 14402 14454 +52
Branches 1375 1380 +5
=========================================
+ Hits 13138 13186 +48
- Misses 878 879 +1
- Partials 386 389 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jack-berg
reviewed
Dec 22, 2022
context/src/main/java/io/opentelemetry/context/ThreadLocalContextStorage.java
Outdated
Show resolved
Hide resolved
context/src/main/java/io/opentelemetry/context/ThreadLocalContextStorage.java
Show resolved
Hide resolved
jack-berg
approved these changes
Dec 22, 2022
mateuszrzeszutek
approved these changes
Dec 28, 2022
jkwatson
approved these changes
Dec 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5055