Skip to content

Mark :extensions:annotations as deprecated#4659

Merged
jack-berg merged 1 commit intoopen-telemetry:mainfrom
jack-berg:deprecate-annotations
Aug 7, 2022
Merged

Mark :extensions:annotations as deprecated#4659
jack-berg merged 1 commit intoopen-telemetry:mainfrom
jack-berg:deprecate-annotations

Conversation

@jack-berg
Copy link
Copy Markdown
Member

As discussed in this PR #4260 comment, we want to move :extensions:annoations to opentelemetry-java-instrumentation so it can live along side its primary implementation in the java agent.

The work to move has been completed in #6245. This is a followup to indicate that the :extensions:annotations is deprecated. We'll continue to publish until 2.0.0 but will not make future changes.

cc @trask

@jack-berg jack-berg requested a review from a user August 2, 2022 20:38
@jack-berg jack-berg requested a review from Oberon00 as a code owner August 2, 2022 20:38
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 2, 2022

Codecov Report

Merging #4659 (53232fa) into main (f5dd63a) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #4659      +/-   ##
============================================
+ Coverage     90.12%   90.13%   +0.01%     
- Complexity     5069     5070       +1     
============================================
  Files           584      584              
  Lines         15649    15649              
  Branches       1503     1503              
============================================
+ Hits          14103    14106       +3     
+ Misses         1092     1091       -1     
+ Partials        454      452       -2     
Impacted Files Coverage Δ
...metry/sdk/metrics/export/PeriodicMetricReader.java 90.00% <0.00%> (+2.85%) ⬆️
...ava/io/opentelemetry/sdk/internal/RateLimiter.java 100.00% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5dd63a...53232fa. Read the comment docs.

@jack-berg jack-berg merged commit 1d63b2a into open-telemetry:main Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants