Simple OTLP HTTP authentication - otel internal api #4630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4630 +/- ##
============================================
+ Coverage 90.05% 90.11% +0.05%
- Complexity 5066 5073 +7
============================================
Files 581 582 +1
Lines 15618 15641 +23
Branches 1497 1500 +3
============================================
+ Hits 14065 14095 +30
+ Misses 1098 1092 -6
+ Partials 455 454 -1
Continue to review full report at Codecov.
|
jkwatson
reviewed
Jul 22, 2022
| (Route route, Response rspns) -> { | ||
| Request.Builder requestBuilder = rspns.request().newBuilder(); | ||
| finalAuthenticator.getHeaders( | ||
| ah -> { |
Contributor
There was a problem hiding this comment.
I don't know this API. What's the type of ah? Can we make the variable name more expressive? Thanks!
Contributor
Author
There was a problem hiding this comment.
expanded to authHeaders
jack-berg
reviewed
Jul 22, 2022
Member
jack-berg
left a comment
jack-berg
left a comment
There was a problem hiding this comment.
Bunch of small comments. Thanks!
...lp/common/src/main/java/io/opentelemetry/exporter/internal/okhttp/OkHttpExporterBuilder.java
Outdated
Show resolved
Hide resolved
...lp/common/src/main/java/io/opentelemetry/exporter/internal/okhttp/OkHttpExporterBuilder.java
Outdated
Show resolved
Hide resolved
...lp/common/src/main/java/io/opentelemetry/exporter/internal/okhttp/OkHttpExporterBuilder.java
Outdated
Show resolved
Hide resolved
...ers/otlp/common/src/test/java/io/opentelemetry/exporter/internal/auth/AuthenticatorTest.java
Outdated
Show resolved
Hide resolved
...ers/otlp/common/src/test/java/io/opentelemetry/exporter/internal/auth/AuthenticatorTest.java
Outdated
Show resolved
Hide resolved
exporters/otlp/common/src/main/java/io/opentelemetry/exporter/internal/auth/Authenticator.java
Outdated
Show resolved
Hide resolved
exporters/otlp/common/src/main/java/io/opentelemetry/exporter/internal/auth/Authenticator.java
Outdated
Show resolved
Hide resolved
exporters/otlp/common/src/main/java/io/opentelemetry/exporter/internal/auth/Authenticator.java
Outdated
Show resolved
Hide resolved
exporters/otlp/common/src/main/java/io/opentelemetry/exporter/internal/auth/Authenticator.java
Outdated
Show resolved
Hide resolved
exporters/otlp/common/src/main/java/io/opentelemetry/exporter/internal/auth/Authenticator.java
Outdated
Show resolved
Hide resolved
…internal/auth/Authenticator.java Co-authored-by: jack-berg <[email protected]>
…internal/auth/Authenticator.java Co-authored-by: jack-berg <[email protected]>
…internal/auth/Authenticator.java Co-authored-by: jack-berg <[email protected]>
…internal/auth/Authenticator.java Co-authored-by: jack-berg <[email protected]>
…internal/okhttp/OkHttpExporterBuilder.java Co-authored-by: jack-berg <[email protected]>
jack-berg
approved these changes
Jul 26, 2022
Member
jack-berg
left a comment
jack-berg
left a comment
There was a problem hiding this comment.
Interested if the contract needs to be void getHeaders(Consumer<Map<String, String>>) or if Map<String, String> getHeaders() would suffice. But looks good otherwise.
Thanks!
jkwatson
approved these changes
Jul 28, 2022
Contributor
jkwatson
left a comment
jkwatson
left a comment
There was a problem hiding this comment.
I don't know enough to know if this is sufficient for all the use-cases needed, but as long as it's just internal for now, 👍🏽
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support simple authentication protocols on OTLP HTTP exporters as discussed in, #4590