Skip to content

Hide exemplars #4276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jack-berg merged 4 commits into from
Mar 22, 2022
Merged

Hide exemplars #4276

jack-berg merged 4 commits into from
Mar 22, 2022

Conversation

@jack-berg
Copy link
Member

@jack-berg jack-berg commented Mar 18, 2022

Resolves #4272.

  • Make exemplar package internal
  • Add method to reflectively assign ExemplarFilter to SdkMeterProviderBuilder

@jack-berg jack-berg requested a review from a user March 18, 2022 14:38
@jack-berg jack-berg requested a review from Oberon00 as a code owner March 18, 2022 14:38
@codecov
Copy link

codecov bot commented Mar 18, 2022 •
edited
Loading

Codecov Report

Merging #4276 (a0a594a) into main (2c695a3) will increase coverage by 0.01%.
The diff coverage is 63.63%.

@@             Coverage Diff              @@
##               main    #4276      +/-   ##
============================================
+ Coverage     89.85%   89.86%   +0.01%     
- Complexity     4826     4827       +1     
============================================
  Files           567      567              
  Lines         15016    15024       +8     
  Branches       1422     1422              
============================================
+ Hits          13493    13502       +9     
+ Misses         1058     1056       -2     
- Partials        465      466       +1
Impacted Files Coverage Δ
...io/opentelemetry/sdk/metrics/SdkMeterProvider.java 92.30% <ø> (ø)
...telemetry/sdk/metrics/SdkMeterProviderBuilder.java 96.66% <ø> (ø)
.../metrics/internal/aggregator/AggregatorHandle.java 93.10% <ø> (ø)
...gregator/DoubleExponentialHistogramAggregator.java 100.00% <ø> (ø)
...internal/aggregator/DoubleHistogramAggregator.java 100.00% <ø> (ø)
...internal/aggregator/DoubleLastValueAggregator.java 100.00% <ø> (ø)
...trics/internal/aggregator/DoubleSumAggregator.java 100.00% <ø> (ø)
...dk/metrics/internal/aggregator/DropAggregator.java 36.36% <ø> (ø)
...s/internal/aggregator/LongLastValueAggregator.java 95.45% <ø> (ø)
...metrics/internal/aggregator/LongSumAggregator.java 100.00% <ø> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c695a3...a0a594a. Read the comment docs.

@jack-berg jack-berg merged commit 322097a into open-telemetry:main Mar 22, 2022
@breedx-splk breedx-splk mentioned this pull request Sep 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkwatson jkwatson Awaiting requested review from jkwatson

@jsuereth jsuereth Awaiting requested review from jsuereth

@Oberon00 Oberon00 Awaiting requested review from Oberon00

1 more reviewer

@anuraaga anuraaga anuraaga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Limit exemplar functionality until stable

2 participants

@jack-berg @anuraaga