Skip to content

Copy the current OpenCensus protos.#134

Merged
bogdandrutu merged 3 commits into
masterfrom
protos
Apr 17, 2019
Merged

Copy the current OpenCensus protos.#134
bogdandrutu merged 3 commits into
masterfrom
protos

Conversation

@bogdandrutu

Copy link
Copy Markdown
Member
  • This PR only modifies the packages, copyright and authors from the initial files.
  • Follow up PRs will update the protos in order to keep a history.
  • In the final state the protos will be moved to a different repo and a Java artifact will be generated from there, but for the moment we keep them here.

@SergeyKanzhelev SergeyKanzhelev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you need a sign off on copy of files, all the modifications will come later, correct?

@bogdandrutu
bogdandrutu force-pushed the protos branch 3 times, most recently from 936d9b9 to 5f3ab17 Compare April 17, 2019 20:22
@bogdandrutu
bogdandrutu merged commit 6928ae2 into master Apr 17, 2019
@bogdandrutu
bogdandrutu deleted the protos branch April 17, 2019 21:07
tigrannajaryan added a commit to tigrannajaryan/opentelemetry-proto that referenced this pull request Jan 10, 2023
…received

This is considered an bug in the spec that was uncovered in the discussion here:
open-telemetry#442 (comment)

I did some spelunking and the "generate" recommendation comes from the very first commit:
open-telemetry@b5bcfff#diff-ef5f80fbf835dd57e14cb9264944f03d80cf6b04cc7671b0e7fb33167c67efcc
where they were copied from Java repo, to which they were copied from OpenCensus
open-telemetry/opentelemetry-java#134 and in OpenCensus the
wording first time appeared here census-instrumentation/opencensus-proto#160
(authored by @SergeyKanzhelev, merged by @bogdandrutu).

We are deleting the requirement to generate a new trace id or span id if an invalid
id is received. The receivers can decide how they want to treat the invalid id (just
like upon receiving any other invalid id), e.g. they may drop it, log an error, accept
the invalid data, etc. We are not going to prescribe a particular receiver behavior
when invalid trace/span id is received.
tigrannajaryan added a commit to open-telemetry/opentelemetry-proto that referenced this pull request Jan 20, 2023
…received (#444)

This is considered an bug in the spec that was uncovered in the discussion here:
#442 (comment)

I did some spelunking and the "generate" recommendation comes from the very first commit:
b5bcfff#diff-ef5f80fbf835dd57e14cb9264944f03d80cf6b04cc7671b0e7fb33167c67efcc
where they were copied from Java repo, to which they were copied from OpenCensus
open-telemetry/opentelemetry-java#134 and in OpenCensus the
wording first time appeared here census-instrumentation/opencensus-proto#160
(authored by @SergeyKanzhelev, merged by @bogdandrutu).

We are deleting the requirement to generate a new trace id or span id if an invalid
id is received. The receivers can decide how they want to treat the invalid id (just
like upon receiving any other invalid id), e.g. they may drop it, log an error, accept
the invalid data, etc. We are not going to prescribe a particular receiver behavior
when invalid trace/span id is received.
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this pull request Jun 21, 2024
…received (open-telemetry#444)

This is considered an bug in the spec that was uncovered in the discussion here:
open-telemetry#442 (comment)

I did some spelunking and the "generate" recommendation comes from the very first commit:
open-telemetry@b5bcfff#diff-ef5f80fbf835dd57e14cb9264944f03d80cf6b04cc7671b0e7fb33167c67efcc
where they were copied from Java repo, to which they were copied from OpenCensus
open-telemetry/opentelemetry-java#134 and in OpenCensus the
wording first time appeared here census-instrumentation/opencensus-proto#160
(authored by @SergeyKanzhelev, merged by @bogdandrutu).

We are deleting the requirement to generate a new trace id or span id if an invalid
id is received. The receivers can decide how they want to treat the invalid id (just
like upon receiving any other invalid id), e.g. they may drop it, log an error, accept
the invalid data, etc. We are not going to prescribe a particular receiver behavior
when invalid trace/span id is received.
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this pull request Jun 21, 2024
…received (open-telemetry#444)

This is considered an bug in the spec that was uncovered in the discussion here:
open-telemetry#442 (comment)

I did some spelunking and the "generate" recommendation comes from the very first commit:
open-telemetry@b5bcfff#diff-ef5f80fbf835dd57e14cb9264944f03d80cf6b04cc7671b0e7fb33167c67efcc
where they were copied from Java repo, to which they were copied from OpenCensus
open-telemetry/opentelemetry-java#134 and in OpenCensus the
wording first time appeared here census-instrumentation/opencensus-proto#160
(authored by @SergeyKanzhelev, merged by @bogdandrutu).

We are deleting the requirement to generate a new trace id or span id if an invalid
id is received. The receivers can decide how they want to treat the invalid id (just
like upon receiving any other invalid id), e.g. they may drop it, log an error, accept
the invalid data, etc. We are not going to prescribe a particular receiver behavior
when invalid trace/span id is received.
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this pull request Jun 21, 2024
…received (open-telemetry#444)

This is considered an bug in the spec that was uncovered in the discussion here:
open-telemetry#442 (comment)

I did some spelunking and the "generate" recommendation comes from the very first commit:
open-telemetry@b5bcfff#diff-ef5f80fbf835dd57e14cb9264944f03d80cf6b04cc7671b0e7fb33167c67efcc
where they were copied from Java repo, to which they were copied from OpenCensus
open-telemetry/opentelemetry-java#134 and in OpenCensus the
wording first time appeared here census-instrumentation/opencensus-proto#160
(authored by @SergeyKanzhelev, merged by @bogdandrutu).

We are deleting the requirement to generate a new trace id or span id if an invalid
id is received. The receivers can decide how they want to treat the invalid id (just
like upon receiving any other invalid id), e.g. they may drop it, log an error, accept
the invalid data, etc. We are not going to prescribe a particular receiver behavior
when invalid trace/span id is received.
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this pull request Jun 21, 2024
…received (open-telemetry#444)

This is considered an bug in the spec that was uncovered in the discussion here:
open-telemetry#442 (comment)

I did some spelunking and the "generate" recommendation comes from the very first commit:
open-telemetry@b5bcfff#diff-ef5f80fbf835dd57e14cb9264944f03d80cf6b04cc7671b0e7fb33167c67efcc
where they were copied from Java repo, to which they were copied from OpenCensus
open-telemetry/opentelemetry-java#134 and in OpenCensus the
wording first time appeared here census-instrumentation/opencensus-proto#160
(authored by @SergeyKanzhelev, merged by @bogdandrutu).

We are deleting the requirement to generate a new trace id or span id if an invalid
id is received. The receivers can decide how they want to treat the invalid id (just
like upon receiving any other invalid id), e.g. they may drop it, log an error, accept
the invalid data, etc. We are not going to prescribe a particular receiver behavior
when invalid trace/span id is received.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants