Packaging OTEP 4793#239
Closed
mmanciop wants to merge 7 commits into
Closed
Conversation
Since we are splitting out autoinstrumentation packages, we also need to split out how they register the presence of the autoinstrumentation, so that the injector does not go look for SDKs that are not installed.
Closed
x1unix
reviewed
Feb 7, 2026
| chmod 755 "${buildroot}${LIBOTELINJECT_INSTALL_PATH}" | ||
|
|
||
| # Install configuration | ||
| mkdir -p "${buildroot}${INJECTOR_CONFIG_DIR}" |
Member
There was a problem hiding this comment.
Can install be used here instead of cp, chmod and mkdir?
Correct me if I'm wrong
Suggested change
| mkdir -p "${buildroot}${INJECTOR_CONFIG_DIR}" | |
| mkdir -p "${buildroot}${INJECTOR_CONFIG_DIR}" | |
| install -d -m 755 "${buildroot}${INJECTOR_CONFIG_DIR}/conf.d" | |
| install -m 644 "$COMMON_DIR/injector/otelinject.conf" "${buildroot}${INJECTOR_CONFIG_DIR}/" | |
| install -m 644 "$COMMON_DIR/injector/default_env.conf" "${buildroot}${INJECTOR_CONFIG_DIR}/" |
This was referenced Mar 16, 2026
atoulme
reviewed
Mar 16, 2026
| @@ -0,0 +1,23 @@ | |||
| #!/bin/sh | |||
|
|
|||
Contributor
There was a problem hiding this comment.
should we set -e in this script?
Contributor
Author
There was a problem hiding this comment.
It would not hurt. But in reality, the only actual commands, are in an if guard
atoulme
reviewed
Mar 16, 2026
| /// Reads configuration drop-in files from the conf.d directory. Each installed language package | ||
| /// (e.g., opentelemetry-java-autoinstrumentation) places its configuration in this directory. | ||
| /// Files are read in alphabetical order; later files can override earlier ones. | ||
| fn readConfigurationDirectory(arena_allocator: std.mem.Allocator, configuration: *InjectorConfiguration) void { |
Contributor
There was a problem hiding this comment.
I'll split to a separate PR to understand how we can land this directly
This was referenced Mar 16, 2026
Merged
Contributor
Author
6 tasks
This was referenced May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing the packaging described in OTEP 4793