Skip to content

otelslog, otelzap: align with code attributes semantic conventions #6870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pellared merged 6 commits into from
Mar 4, 2025
Merged

otelslog, otelzap: align with code attributes semantic conventions #6870

pellared merged 6 commits into from
Mar 4, 2025

Conversation

@pellared
Copy link
Member

@pellared pellared commented Mar 3, 2025 •
edited
Loading

Why

Fixes #6869

Related to:

What

  • The code.function attribute emitted by the log bridges stores package path-qualified function name.
  • The code.namespace attribute is no longer added.

@github-actions github-actions bot requested review from MrAlias and khushijain21 March 3, 2025 11:59
@pellared pellared added bridge: slog Related to the slog bridge bridge: zap Related to the zap bridge labels Mar 3, 2025
@pellared pellared changed the title Code-attrs otelslog, otelzap: Align with code semantic conventions Mar 3, 2025
@codecov
Copy link

codecov bot commented Mar 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.0%. Comparing base (053acd0) to head (8a9655a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6870     +/-   ##
=======================================
- Coverage   76.1%   76.0%   -0.1%     
=======================================
  Files        219     219             
  Lines      21315   21299     -16     
=======================================
- Hits       16226   16207     -19     
- Misses      4529    4531      +2     
- Partials     560     561      +1
Files with missing lines Coverage Δ
bridges/otelslog/handler.go 93.1% <100.0%> (-0.3%) ⬇️
bridges/otelzap/core.go 97.7% <100.0%> (-0.2%) ⬇️

... and 1 file with indirect coverage changes

@pellared pellared changed the title otelslog, otelzap: Align with code semantic conventions otelslog, otelzap: Align with code attributes semantic conventions Mar 3, 2025
@pellared pellared marked this pull request as ready for review March 3, 2025 12:04
@pellared pellared requested a review from a team as a code owner March 3, 2025 12:04
@pellared pellared changed the title otelslog, otelzap: Align with code attributes semantic conventions otelslog, otelzap: align with code attributes semantic conventions Mar 3, 2025
MrAlias
MrAlias approved these changes Mar 3, 2025
View reviewed changes
@pellared pellared merged commit b84ed3a into open-telemetry:main Mar 4, 2025
31 checks passed
@pellared pellared deleted the code-attrs branch March 4, 2025 05:52
@XSAM XSAM added this to the v1.35.0 milestone Mar 4, 2025
@XSAM XSAM mentioned this pull request Mar 5, 2025
Merged
@pellared pellared mentioned this pull request Mar 6, 2025
Merged
3 tasks
@xrmx xrmx mentioned this pull request Mar 26, 2025
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmathieu dmathieu dmathieu approved these changes

@MrAlias MrAlias MrAlias approved these changes

@khushijain21 khushijain21 Awaiting requested review from khushijain21

Assignees

No one assigned

Labels

bridge: slog Related to the slog bridge bridge: zap Related to the zap bridge

Projects

None yet

Milestone

v1.35.0

Development

Successfully merging this pull request may close these issues.

log bridges: Align with code sementic conventions update

4 participants

@pellared @dmathieu @MrAlias @XSAM