Don't write headers on Write if they were already written
#6055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
approved these changes
Aug 27, 2024
MrAlias
approved these changes
Aug 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6055 +/- ##
=====================================
Coverage 65.5% 65.5%
=====================================
Files 203 203
Lines 12984 12985 +1
=====================================
+ Hits 8505 8506 +1
Misses 4219 4219
Partials 260 260
|
BuJo
added a commit
to synyx/tuwat
that referenced
this pull request
Sep 1, 2024
johnduhart
pushed a commit
to mdsol/opentelemetry-go-contrib
that referenced
this pull request
Sep 6, 2024
…emetry#6055) The change in open-telemetry#5916 introduced a regression, as we don't check whether the header was written before writing it in `Write()`. We need to only write if the header wasn't written yet. Fixes open-telemetry#6053. --------- Co-authored-by: Tyler Yahn <[email protected]>
XSAM
added a commit
that referenced
this pull request
Sep 11, 2024
### Added - Add `NewProducer` to `go.opentelemetry.io/contrib/instrumentation/runtime`, which allows collecting the `go.schedule.duration` histogram metric from the Go runtime. (#5991) - Add gRPC protocol support for OTLP log exporter in `go.opentelemetry.io/contrib/exporters/autoexport`. (#6083) ### Removed - Drop support for [Go 1.21]. (#6046, #6047) ### Fixed - Superfluous call to `WriteHeader` when flushing after setting a status code in `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp`. (#6074) - Superfluous call to `WriteHeader` when writing the response body after setting a status code in `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp`. (#6055) [Go 1.21]: https://go.dev/doc/go1.21 --------- Co-authored-by: Tyler Yahn <[email protected]>
felipeweb
added a commit
to funccloud/weaver
that referenced
this pull request
Oct 18, 2024
…emetry/opentelemetry-go-contrib#6055. Signed-off-by: Felipe Oliveira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in #5916 introduced a regression, as we don't check whether the header was written before writing it in
Write().We need to only write if the header wasn't written yet.
Fixes #6053.