Skip to content

Use top-level common SemVersion() in creation of versioned tracer for bradfitz/gomemcache - #226

Merged
Aneurysm9 merged 6 commits into
open-telemetry:masterfrom
evantorrie:fitzcache-semversion
Aug 16, 2020
Merged

Aneurysm9 merged 6 commits into
open-telemetry:masterfrom
evantorrie:fitzcache-semversion

Conversation

@evantorrie

Copy link
Copy Markdown
Contributor

This depends on #225, which would need to be merged prior to this.

Also noticed this module was missing from the dependabot.yml checks.

@MrAlias MrAlias left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks for the catch!

Comment thread contrib.go Resolved
@Aneurysm9
Aneurysm9 force-pushed the fitzcache-semversion branch from 9bd1ebb to 8947977 Compare August 16, 2020 15:56
@Aneurysm9
Aneurysm9 merged commit 0cce6d2 into open-telemetry:master Aug 16, 2020
@evantorrie
evantorrie deleted the fitzcache-semversion branch August 16, 2020 19:38
plantfansam referenced this pull request in plantfansam/opentelemetry-go-contrib Mar 18, 2022
* api(trace): change trace id to byte array.

* fix lint errors

* add helper to create trace id from hex and improve stdout exporter.

* remove comma.

* fix lint

* change TraceIDFromHex to be compliant with w3 trace-context

* revert remove of hex16 regex because its used to parse SpanID

* lint

* fix typo
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants