semconvgen: Quickfix after semconv repo migration#374
Merged
pellared merged 4 commits intoopen-telemetry:mainfrom Jul 26, 2023
pellared:semconvgen-quickfix
Merged
semconvgen: Quickfix after semconv repo migration#374pellared merged 4 commits intoopen-telemetry:mainfrom pellared:semconvgen-quickfix
pellared merged 4 commits intoopen-telemetry:mainfrom
pellared:semconvgen-quickfix
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #374 +/- ##
=======================================
Coverage 62.07% 62.07%
=======================================
Files 48 48
Lines 2344 2344
=======================================
Hits 1455 1455
Misses 741 741
Partials 148 148 ☔ View full report in Codecov by Sentry. |
pellared
changed the title
mx-psi
approved these changes
Jul 25, 2023
MrAlias
approved these changes
Jul 25, 2023
Co-authored-by: Tyler Yahn <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is "quickfix" for
semconvgenso that the OTel Collector and Go can usesemconvgenafter the semantic conventions moved from https://github.com/open-telemetry/opentelemetry-specification to https://github.com/open-telemetry/semantic-conventions.This change was tested as part of open-telemetry/opentelemetry-go#4362
A more sophisticated way would be probably to have two args in
semconvgen; one for the Git repository and second for folder when the YAML definitions reside. However, I think that it may be not worth the effort and could introduce more problems than benefits (both OTel Collector and Go would need to update their semconv generation scripts).