Upgrade OTLP exporter to opentelemetry-proto matching the opentelemetry-collector v0.4.0 release #866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The labels are no longer included in the MetricDescriptor Use new types.
MrAlias
added
bug
MrAlias
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey and
paivagustavo
as code owners
nilebox
reviewed
Jun 24, 2020
jmacd
approved these changes
Jun 24, 2020
Recreate go.sum for otel-collector example and OTLP exporter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were breaking changes in the OTLP protocol, making Go SDK incompatible with Collector v0.4.0.
This does not plug in the new features of the SDK as the OTLP is still being built to support this. Rather this is throw-away work for the interim to support the direction the proto repo is going in open-telemetry/opentelemetry-proto#79
A second PR is needed to fully couple the SDK to the OTLP once the OTLP has settled on a form that supports OTel.
Resolves #845
Resolves #852