Eliminate Uint64NumberKind from API #864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes open-telemetry#851 This includes all of the associated methods, such as AsUint64, AsUint64Atomic, AsUint64Ptr, CoerceToUint64, SetUint64 SetUint64Atomic, SwapUint64, SwapUint64Atomic, AddUint64, AddUint64Atomic, CompamreAndSwapUint64, CompareUint64 Only significant change as a result was converting the histogram aggregator's `count` state field into an int64 from a `metric.Number`.
evantorrie
requested review from
Aneurysm9,
MrAlias,
jmacd,
lizthegrey and
paivagustavo
as code owners
jmacd
approved these changes
Jun 23, 2020
MrAlias
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #851
This includes all of the associated methods, such as
AsUint64, AsUint64Atomic, AsUint64Ptr, CoerceToUint64, SetUint64
SetUint64Atomic, SwapUint64, SwapUint64Atomic, AddUint64,
AddUint64Atomic, CompareAndSwapUint64, CompareUint64
Only significant change as a result was converting the histogram aggregator's
countstate field into an int64 from ametric.Number.