Add default metrics to othttp instrumentation Fixes #542 #861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewGrachov
requested review from
Aneurysm9,
MrAlias,
evantorrie,
jmacd,
lizthegrey and
paivagustavo
as code owners
|
|
Member
|
@AndrewGrachov please ensure your commit email address is the same as your github email address |
lizthegrey
added
the
blocked:CLA
AndrewGrachov
force-pushed
the
othttp-metrics
branch
from
30091f4 to
06dc710
Compare
AndrewGrachov
changed the title
Contributor
Author
|
I signed it |
lizthegrey
removed
the
blocked:CLA
jmacd
approved these changes
Jun 23, 2020
Contributor
jmacd
left a comment
jmacd
left a comment
There was a problem hiding this comment.
These are just some nits. Fine to merge as-is.
Contributor
|
I should add that there is an effort to standardize the metrics we get from span-oriented calls, here: open-telemetry/opentelemetry-specification#654 When this standard is finished, we'll probably want to change this instrumentation. Have you given your input on that issue? |
Aneurysm9
reviewed
Jun 23, 2020
MrAlias
reviewed
Jun 23, 2020
evantorrie
reviewed
Jun 23, 2020
Contributor
Author
|
I signed it |
Aneurysm9
reviewed
Jun 24, 2020
jmacd
reviewed
Jun 24, 2020
Aneurysm9
approved these changes
Jun 24, 2020
MrAlias
approved these changes
Jun 26, 2020
Contributor
MrAlias
left a comment
MrAlias
left a comment
There was a problem hiding this comment.
LGTM. Minor punctuation and capitalization changes requested, but nothing is a blocker.
Co-authored-by: Tyler Yahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.