Skip to content

Bumps github.com/golang/protobuf from 1.3.2 to 1.4.2 #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lizthegrey merged 6 commits into from
Jun 22, 2020
Merged

Bumps github.com/golang/protobuf from 1.3.2 to 1.4.2 #848

lizthegrey merged 6 commits into from
Jun 22, 2020

Conversation

@lizthegrey
Copy link
Member

@lizthegrey lizthegrey commented Jun 22, 2020 •
edited
Loading

Upgrades github.com/golang/protobuf from v1.3.2 to v1.4.2

Supersedes #821

@lizthegrey lizthegrey changed the title Replaces github.com/golang/protobuf with google.golang.org/protobuf/proto Bumps github.com/golang/protobuf from 1.3.2 to 1.4.2 Jun 22, 2020
@lizthegrey lizthegrey added the dependencies Pull requests that update a dependency file label Jun 22, 2020
@lizthegrey lizthegrey marked this pull request as ready for review June 22, 2020 20:52
@evantorrie evantorrie added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Jun 22, 2020
@lizthegrey
Copy link
Member Author

lizthegrey commented Jun 22, 2020

The dep tidier won't run because it lacks permissions to write to honeycombio repos.

But the tests pass.

@lizthegrey lizthegrey merged commit e5267a3 into open-telemetry:master Jun 22, 2020
@lizthegrey lizthegrey deleted the lizf.proto branch June 22, 2020 21:59
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@jmacd jmacd Awaiting requested review from jmacd

@MrAlias MrAlias Awaiting requested review from MrAlias

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

1 more reviewer

@evantorrie evantorrie evantorrie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

untracked

Development

Successfully merging this pull request may close these issues.

3 participants

@lizthegrey @evantorrie @pellared