Bump github.com/stretchr/testify from 1.4.0 to 1.6.1 #824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependabot
bot
requested review from
Aneurysm9,
MrAlias,
evantorrie,
jmacd,
lizthegrey and
paivagustavo
as code owners
dependabot
bot
added
the
dependencies
|
|
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/stretchr/testify-1.6.1
branch
7 times, most recently
from
a3788fc to
1d3685f
Compare
lizthegrey
approved these changes
Jun 22, 2020
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/stretchr/testify-1.6.1
branch
from
1d3685f to
4bdb791
Compare
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.4.0 to 1.6.1. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.4.0...v1.6.1) Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/stretchr/testify-1.6.1
branch
from
4bdb791 to
e6c834b
Compare
lizthegrey
added
dependencies
Contributor
|
This is failing because of this PR fix in testify-1.6.1 stretchr/testify#919 |
Member
So if I understand correctly, we need to fix our test accordingly? |
Contributor
|
So, this must have always been the case - just that the bug in testify never caused the test to fail. |
Math is hard
evantorrie
added
dependencies
evantorrie
added
dependencies
lizthegrey
reviewed
Jun 22, 2020
Member
lizthegrey
left a comment
lizthegrey
left a comment
There was a problem hiding this comment.
defer to @jmacd to understand the meaning of the test.
Contributor
|
Been a while since I looked at IEEE 754 in detail, but per http://www.validlab.com/goldberg/paper.ps (referenced by the Wikipedia article on IEEE 754 FP),
|
evantorrie
approved these changes
Jun 23, 2020
jmacd
reviewed
Jun 23, 2020
jmacd
approved these changes
Jun 23, 2020
jmacd
deleted the
dependabot/go_modules/github.com/stretchr/testify-1.6.1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/stretchr/testify from 1.4.0 to 1.6.1.
Release notes
Sourced from github.com/stretchr/testify's releases.
Commits
f654a91Update Go versions in Travis3184a9eThis reverts commit 0a813b5898c0ee8d00b4f13fae21ea5df8b35e74.e2b269eThis reverts commit 2adb7b54b75da2c74e9342ed115957fe0b07e0b4.6353e56This reverts commit 9d083cac4a26c76f8d92dff41d459f3f2fc0b911.6561324This reverts commit 484fff1ace1f0acb84676a548b53477685c16414.46420cfThis reverts commit 1a43b8334acb9df58064b765cd16675cc7c2c8b3.303198dRevert "allow body for HTTPBodyContains and HTTPBodyNotContains fore7cc868Update TravisCI config004e3cbcommit generated filesac1463fImplement NotEqualValuesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)