Send configured headers with every request #806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
requested review from
Aneurysm9,
MrAlias,
evantorrie,
jmacd,
lizthegrey and
paivagustavo
as code owners
MrAlias
reviewed
Jun 9, 2020
Contributor
MrAlias
left a comment
MrAlias
left a comment
There was a problem hiding this comment.
Seems reasonable to me overall. I made some minor suggestions, but looks close.
Co-authored-by: Tyler Yahn <[email protected]>
jmacd
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a user, I expect that any headers I configure via
WithHeadersbe sent with every request sent to the collector. This PR fixes that.