Fix global handler_test.go test failure #804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On slower VMs (like the CI VMs), this test was timing out in 2ms and failing. Additionally, in the process of failing, the suite tear-down function would reset the globalHandler and cause a race with the spawned goroutine that was abandoned. This increases the pause from 2ms to 10ms, unifies and simplifies the wait logic, and stops the child goroutine on failure.
MrAlias
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey and
paivagustavo
as code owners
MrAlias
changed the title
jmacd
approved these changes
Jun 9, 2020
Contributor
Author
|
Looks like this is still occasionally failing: https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-go/2318/workflows/236422f0-b620-4fd3-bd62-5a11fdb43af4/jobs/2873/steps Going to look at using the change in |
Contributor
Author
|
Ran the CI build 3x (6x if you count each job individually) and all successful. I think b2b9149 was the fix for the underlying issue. An added benefit of not fixing it right away was the data race was also shown to be resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On slower VMs (like the CI VMs), this test was timing out in 2ms and failing. Additionally, in the process of failing, the suite tear-down function would reset the globalHandler and cause a race with the spawned goroutine that was abandoned.
This increases the pause from 2ms to 10ms, unifies and simplifies the wait logic, and stops the child goroutine on failure.